Updates allennlp version

allenai / allennlp-hub

A collection of selected of models built with AllenNLP.

Apache License 2.0

25 stars 9 forks source link

Updates allennlp version #17

Closed dirkgr closed 4 years ago

schmmd commented 4 years ago

I was about to do just this, but got nervous that the other libraries are not updated too. We'll see if the tests pass ;-)

dirkgr commented 4 years ago

Aww. Let me re-iterate my opinion that hub tests need to run on every PR, and PRs do not get merged until hub tests finish.

Because I can guarantee you that we fix this now, and next week it'll be broken again.

matt-gardner commented 4 years ago

The trouble is that you can't really make that work, as you'd have to merge code in a separate repo in order to get the PR to pass CI, and that means that the hub CI has to depend on a PR branch of the main repo, and it just doesn't work.