Add pretrained models and sniff tests for `allennlp_semparse`.

allenai / allennlp-hub

A collection of selected of models built with AllenNLP.

Apache License 2.0

25 stars 9 forks source link

Add pretrained models and sniff tests for `allennlp_semparse`. #4

Closed brendan-ai2 closed 4 years ago

brendan-ai2 commented 4 years ago

For https://github.com/allenai/allennlp/issues/3351.
Conveniently https://github.com/allenai/allennlp/pull/3361 broke allennlp_semparse a while back, so the (AllenNLP Hub Master Build)[http://build.allennlp.org/viewType.html?buildTypeId=AllenNLPHub_Master] should break when this PR merged.
- We should then fix allennlp-semparse and verify that the build goes green.

brendan-ai2 commented 4 years ago

@matt-gardner, here are the additional sniff tests we discussed. If you'd also like to use this PR as an opportunity to give feedback on the setup of allennlp-hub more broadly, please feel free!

matt-gardner commented 4 years ago

Putting the tests inside the package isn't necessarily a problem, I just don't think it's typical.

brendan-ai2 commented 4 years ago

Sounds good. Moved tests up one level. This appears to fit the distutils model as well, which maintains a distinction between source and built distributions. Details: https://docs.python.org/3/distutils/sourcedist.html

brendan-ai2 commented 4 years ago

Thanks again! I'm going to merge and get that second TeamCity build up and running.