search

allenai / allennlp-reading-comprehension

81 stars 25 forks source link

Move RC models to this repo, and bring it up to date #11

Closed dirkgr closed 4 years ago

dirkgr commented 4 years ago

This is a port from https://github.com/allenai/allennlp/commit/2850579831f392467276f1ab6d5cda3fdb45c3ba, so that this repo at least runs again.

dirkgr commented 4 years ago

These tests won't succeed until we update https://github.com/allenai/allennlp-reading-comprehension/blob/master/requirements.txt#L2. @matt-gardner, did you point that to a special commit, or can I just update this to the latest master?

dirkgr commented 4 years ago

I see now what is special about the allennlp commit you pointed it to.

With this now pointing to master, tests will keep failing until #12 is merged.

matt-gardner commented 4 years ago

I updated https://github.com/allenai/allennlp/pull/3348, so it should hopefully be good to merge once tests pass (I probably won't be able to get back to github much today; feel free to do the merge yourself if it looks good). Then we can just point to master.

There is one commit with things from master that need to be migrated to this repo: https://github.com/allenai/allennlp/pull/3348/commits/39cd9f95a6c095cafd868598de39c0df2e2c9fef. I think you got some of these, but I'm not sure that you got all of them.