search

allenai / allennlp-semparse

A framework for building semantic parsers (including neural module networks) with AllenNLP, built by the authors of AllenNLP
Apache License 2.0
107 stars 24 forks source link

Handling currying of composed functions #31

Closed matt-gardner closed 3 years ago

matt-gardner commented 3 years ago

My previous improvements to the domain language code added function composition and currying, and handled the case where you want to compose curried functions. It did not handle the case where you want to curry composed functions. This PR adds that ability (though as of the initial commit, not all tests are passing - there are four main functions that need to support this, and so far only two of them do).

Motivated by the failing tests in #30; this PR checks the same functionality in the main test language, instead of in the NLVR language. cc @nitishgupta.

matt-gardner commented 3 years ago

Alright @nitishgupta, I believe this now fixes all issues and is ready for review.

nitishgupta commented 3 years ago

I've looked at the code at a high-level and it looks good. I don't think I'll be able to catch deep-seated issues if any. @matt-gardner, you can go ahead and merge this; I'll incorporate this in #30 then