allenai / allennlp-semparse

A framework for building semantic parsers (including neural module networks) with AllenNLP, built by the authors of AllenNLP
Apache License 2.0
107 stars 24 forks source link

Clarify implicit dependency `overrides`; semparse broken with allennlp 2.9 #55

Closed h-vetinari closed 2 years ago

h-vetinari commented 2 years ago

By chance, https://github.com/conda-forge/allennlp-semparse-feedstock/pull/4 showed that allennlp-semparse is broken with allennlp 2.9, because the latter removed the dependence on overrides, but semparse depended on it implicitly coming from allennlp.

Either the dependency (and version range) should be specified, or the dependence on overrides removed.

CC @dirkgr @epwalsh

epwalsh commented 2 years ago

Thanks @h-vetinari, we should just remove overrides altogether.