search

allenai / allennlp

An open-source NLP research library, built on PyTorch.
http://www.allennlp.org
Apache License 2.0
11.74k stars 2.24k forks source link

Missing `f` prefix on f-strings #5628

Closed code-review-doctor closed 2 years ago

code-review-doctor commented 2 years ago

Some strings looks like they're meant to be f-strings but are missing the f prefix meaning variable interpolation won't happen.

https://github.com/allenai/allennlp/blob/0d25f967c7996ad4980c7ee2f4c71294f51fef80/allennlp/nn/util.py#L758 https://github.com/allenai/allennlp/blob/0d25f967c7996ad4980c7ee2f4c71294f51fef80/scripts/py2md.py#L112 https://github.com/allenai/allennlp/blob/0d25f967c7996ad4980c7ee2f4c71294f51fef80/scripts/py2md.py#L113

I found this issue automatically. I'm a bot. Beep Boop 🦊. See other issues I found in your repo here