allenai / allennlp

An open-source NLP research library, built on PyTorch.
http://www.allennlp.org
Apache License 2.0
11.72k stars 2.25k forks source link

FBetaMeasure metric with one value per key #5638

Closed eraldoluis closed 2 years ago

eraldoluis commented 2 years ago

Fixes #5637 .

Changes proposed in this pull request:

Before submitting

After submitting

eraldoluis commented 2 years ago

Thank you @dirkgr for reviewing this PR. I made the suggested changes.

dirkgr commented 2 years ago

It seems to be failing tests. I put an updated version at https://github.com/allenai/allennlp/pull/5651 that fixes some things, but it looks like the actual test for the new metric is failing.

eraldoluis commented 2 years ago

It seems to be failing tests. I put an updated version at #5651 that fixes some things, but it looks like the actual test for the new metric is failing.

Thank you, @dirkgr , for pointing this issue. There were two tests missing adaptation from the older version. They have now passed in my tests.

I have also incorporated your edits from #5651 .

dirkgr commented 2 years ago

Thank you for sticking with it!

eraldoluis commented 2 years ago

Thank you for your support!