Closed eraldoluis closed 2 years ago
Thank you @dirkgr for reviewing this PR. I made the suggested changes.
It seems to be failing tests. I put an updated version at https://github.com/allenai/allennlp/pull/5651 that fixes some things, but it looks like the actual test for the new metric is failing.
It seems to be failing tests. I put an updated version at #5651 that fixes some things, but it looks like the actual test for the new metric is failing.
Thank you, @dirkgr , for pointing this issue. There were two tests missing adaptation from the older version. They have now passed in my tests.
I have also incorporated your edits from #5651 .
Thank you for sticking with it!
Thank you for your support!
Fixes #5637 .
Changes proposed in this pull request:
Before submitting
CONTRIBUTING
docs.CONTRIBUTING
docs.After submitting
codecov/patch
reports high test coverage (at least 90%). You can find this under the "Actions" tab of the pull request once the other checks have finished.