Relax requirements on protobuf to allow for minor changes and patches. - Githubissues

allenai / allennlp

An open-source NLP research library, built on PyTorch.

http://www.allennlp.org

Apache License 2.0

11.71k stars 2.24k forks source link

Relax requirements on protobuf to allow for minor changes and patches. #5694

Closed lewisbails closed 1 year ago

lewisbails commented 1 year ago

Changes proposed in this pull request:

Relaxed protobuf requirement from protobuf==3.20.0 to protobuf>=3.20.0,<4.0.0, to allow for security patch 3.20.1 patch on protobuf

Before submitting

[x] I've read and followed all steps in the Making a pull request section of the CONTRIBUTING docs.
[x] I've updated or added any relevant docstrings following the syntax described in the Writing docstrings section of the CONTRIBUTING docs.
[ ] If this PR fixes a bug, I've added a test that will fail without my fix.
[ ] If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

[ ] All GitHub Actions jobs for my pull request have passed.
[ ] codecov/patch reports high test coverage (at least 90%). You can find this under the "Actions" tab of the pull request once the other checks have finished.

dirkgr commented 1 year ago

Thank you!