Added for saving git info

allenai / allennlp

An open-source NLP research library, built on PyTorch.

http://www.allennlp.org

Apache License 2.0

11.74k stars 2.25k forks source link

Added for saving git info #5701

Open Shreyz-max opened 2 years ago

Shreyz-max commented 2 years ago

Change proposed in this pull request: Saving git repo infos in meta class along with metadata of model archives after going through #4862 issue

Before submitting

[x] I've read and followed all steps in the Making a pull request section of the CONTRIBUTING docs.
[x] I've updated or added any relevant docstrings following the syntax described in the Writing docstrings section of the CONTRIBUTING docs.
[ ] If this PR fixes a bug, I've added a test that will fail without my fix.
[ ] If this PR adds a new feature, I've added tests that sufficiently cover my new functionality.

After submitting

[ ] All GitHub Actions jobs for my pull request have passed.
[ ] codecov/patch reports high test coverage (at least 90%). You can find this under the "Actions" tab of the pull request once the other checks have finished.

dirkgr commented 2 years ago

Looks good. Can you also add a changelog entry?

Shreyz-max commented 2 years ago

Looks good. Can you also add a changeling entry?

Do you mean adding it into the changelog?

dirkgr commented 2 years ago

Yes, sorry for the typo. Autocorrect, am I right? 😅

Shreyz-max commented 2 years ago

Haha, happens to the best of us.

Shreyz-max commented 2 years ago

Hey @dirkgr this is my first time working on open source and I think by mistake I disabled auto-merge. Also, I have no clue why the tests are not passing. Could you give me some ideas on where and how to start? It will be really helpful.

dirkgr commented 2 years ago

I think auto-merge automatically disables itself when you make a change. Otherwise anyone could push to the branch and it would get merged. It's a safety feature in GitHub.

Let's see if those tests are even still failing.

dirkgr commented 2 years ago

I'm afraid this is a real test failure. The tests now seem to require your git repo to be in a very defined state. We can't have that. It breaks our own tests, and it'll certainly break the tests that @h-vetinari runs in conda-forge.

Shreyz-max commented 2 years ago

So what should be done next?

dirkgr commented 2 years ago

Look at the error and decide on a path to fix it. It looks to me like it's trying to determine the name of the current branch. What should happen if there isn't a current branch? What should happen if the code is run outside of a git repository?