allenai / allennlp

An open-source NLP research library, built on PyTorch.

http://www.allennlp.org

Apache License 2.0

11.71k stars 2.24k forks source link

will update to support latest pytorch? #5713

Closed liusiye1994 closed 1 year ago

liusiye1994 commented 1 year ago

pytorch has released 1.12.1 yet. Any schedule about supporting this version of torch?

dirkgr commented 1 year ago

5714

I'm surprised dependabot didn't open a PR for this?

dirkgr commented 1 year ago

Actually, it did, but there was a problem with it. The correct PR is #5680.

liusiye1994 commented 1 year ago

Actually, it did, but there was a problem with it. The correct PR is #5680.

tks! seems some gpu tests failed?

yukw777 commented 1 year ago

When do you think #5680 will be released?

dirkgr commented 1 year ago

Yeah, I'm looking into it, but I got sick so it's a bit delayed now. Sorry! If you can think of a way to fix the tests I'd be happy to review and approve.

dirkgr commented 1 year ago

It's done!

dirkgr commented 1 year ago

Well, it's merged, but not released yet.

yukw777 commented 1 year ago

@dirkgr thanks! any ETA on the new release?

dirkgr commented 1 year ago

Just made the release!