allenai / allennlp

An open-source NLP research library, built on PyTorch.
http://www.allennlp.org
Apache License 2.0
11.71k stars 2.24k forks source link

Remove upper bounds for dependencies in `requirements.txt` #5733

Closed aphedges closed 1 year ago

aphedges commented 1 year ago

Closes #5728.

Changes proposed in this pull request:

Before submitting

After submitting


The stated reason for this pinning was to prevent CI breakage, and there was a bot to help upgrade dependencies automatically. However, now that the library is being retired and Depdendabot was, this upgrade process is no longer happening.

Removing these upper bounds will make using the library in the future much easier. To prevent CI breakage after upper bound removal, they can be kept in a constraints file for use in CI. It would be up to end users in the future to limit dependency conflicts if they encounter any.

I have checked the history, and as far as I can tell, none of these upper pins exist to prevent a known breakage. Therefore, I moved them all to the constraints file.

aphedges commented 1 year ago

@epwalsh, I have created a PR. You mentioned in https://github.com/allenai/allennlp/issues/5728#issuecomment-1314351630 that you would review it.

Because some of the changes I made are to CI itself, I can't properly test this locally. I'd appreciate if you could approve the GitHub Actions workflows.

aphedges commented 1 year ago

I see there are some failing tests. I'll investigate and see if I can fix the problem.

aphedges commented 1 year ago

It turns out that I missed using the constraints file in several places. The most difficult was to get it working properly with pip-compile, but https://github.com/jazzband/pip-tools/issues/1551 fortunately explained how to do so.