allenai / bff

Apache License 2.0
38 stars 9 forks source link

lint fixes #8

Closed chris-ha458 closed 1 year ago

chris-ha458 commented 1 year ago

cargo clippy returns clean. `cargo clippy -- -Wclippy::pedantic' still returns some warnings. (This isn't bad in of itself since pedantic has false positives, but it would be best to either avoid relevant errors. IF they are indeed working as intended we could suppress them)

To do any further refactoring, we would need tests, and for integration tests some test vectors could be useful.