Fix R2 profile and errors

allenai / cached_path

A file utility for accessing both local and remote files through a unified interface.

https://cached-path.readthedocs.io/

Apache License 2.0

35 stars 11 forks source link

Fix R2 profile and errors #233

Closed 2015aroras closed 3 months ago

2015aroras commented 3 months ago

This PR fixes 2 issues:

Using an AWS profile to authenticate doesn't work, since the profile name is passed to the S3 client rather than a session.
FileNotFoundError is not being thrown when the only issue is that the object does not exists.

2015aroras commented 3 months ago

The tests are breaking because of the following error. I can't see the dataset on beaker myself. Any ideas @epwalsh? beaker.exceptions.DatasetNotFound: 'petew/cached-path-readme': Make sure you're using a valid Beaker dataset ID or the *full* name of the dataset (with the account prefix, e.g. 'username/dataset_name')

epwalsh commented 3 months ago

@2015aroras yea the test fixture beaker dataset must have been deleted. I'll follow up with a separate PR to fix that.

epwalsh commented 3 months ago

Fixes the beaker test here: https://github.com/allenai/cached_path/pull/234