theoretical fix for dot product selector

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)

Apache License 2.0

404 stars 132 forks source link

theoretical fix for dot product selector #109

Closed DeNeutoy closed 8 years ago

DeNeutoy commented 8 years ago

Incomplete work for fixing the knowledge selection process.

DeNeutoy commented 8 years ago

These fixes aren't actually being tested at the moment as none of the memory network tests explicitly test on masked inputs. Additionally, we need to design some test which just checks that if we use masks, they are propagated to all the layers we think they should be, because currently we have no way to check - the default would just be None and it would still compile.

matt-gardner commented 8 years ago

This PR was merged into #108.