allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 132 forks source link

Adaptive memory network #116

Closed DeNeutoy closed 7 years ago

DeNeutoy commented 8 years ago

New PR for this after a rebase, so Semaphore can run tests.

DeNeutoy commented 8 years ago

@matt-gardner This last commit has everything you need to run the adaptive example which crashes - you'll have to change the path to the data files but apart from that it should recreate the problem I was having earlier.

DeNeutoy commented 8 years ago

This is ready for review. This looks kinda big, but it's inflated by the fact I added in the super calls everywhere.

The main changes are:

I've also added a test which checks that TF and keras are optimising the same variables. Let me know if you think there are more tests I should add, happy to do so.

DeNeutoy commented 8 years ago

Also the logic for what is happening with the halting is complicated, might be best for me to explain that on a whiteboard as there are various parts to it which look very similar but are actually time-delayed by one iteration etc.