search

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 132 forks source link

write model hashes for a given evalutation to a text file #124

Closed DeNeutoy closed 7 years ago

DeNeutoy commented 7 years ago

What do you think of this? The only case that I think this won't work is if you try to re-run the exact same evaluation or one with the same name as another one. I guess we could have the evaluation hash as well as the evaluation name in the filename?

DeNeutoy commented 7 years ago

Maybe with a timestamp as well - this would make all the evaluation files unique.

matt-gardner commented 7 years ago

I think having the modelHashFile's path be s"/efs/data/dlfa/evaluations/${name}_${hash}.txt is a good idea. Putting the timestamp in there too is unnecessary - if two evaluation hashes are identical, the file contents will be identical. But encouraging the convention of putting a date in the evaluation name is probably a good idea.