search

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 133 forks source link

Add MCReadingComprehensionInstance to get Johannes' data into the pipeline #168

Closed nelson-liu closed 7 years ago

nelson-liu commented 7 years ago

This PR contains a reader to convert johannes dataset in json format to a format that can be combined with background info from Lucene. It includes tests for the reader and the necessary supporting classes.

@matt-gardner i'm not sure if I properly did experiments/Johannes.scala, do we integrate lucene at this step or the next?

nelson-liu commented 7 years ago

@matt-gardner fixed the quick comments you gave, will try to add the new steps in a bit.

matt-gardner commented 7 years ago

Let me know when I should look at this again.

matt-gardner commented 7 years ago

Ok, I'm done looking at this again. I should have just started a review, instead of adding single comments. Oops...

nelson-liu commented 7 years ago

this is ready to be looked at again, @matt-gardner