tuple_match layer - Githubissues

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)

Apache License 2.0

404 stars 132 forks source link

Closed BeckySharp closed 7 years ago

BeckySharp commented 7 years ago

Today I added mask handling, and wrote a test for it. I am not 110% sure it's what is needed, so please review.

nelson-liu commented 7 years ago

(it's failing tests right now because i have yet to merge #167 , will rerun when i merge that in a bit)

matt-gardner commented 7 years ago

Ok, I'll just ignore travis for this PR, and use the semaphore result. I'll remove semaphore after my PR removing the scala code goes through.

nelson-liu commented 7 years ago

i merged master into this to get the latest config changes from travis

matt-gardner commented 7 years ago

The semaphore failure seems pretty flaky to me; not sure what's going on there. But travis passed, so I'm going to merge this now.