Made self._get_encoder() work with no arguments

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)

Apache License 2.0

404 stars 132 forks source link

Made self._get_encoder() work with no arguments #201

Closed matt-gardner closed 7 years ago

matt-gardner commented 7 years ago

If you just want to call self._get_encoder(), and you don't specify a default key in the encoder params, the code would crash before this PR, even though we know how to handle a default encoder without any parameters.

nelson-liu commented 7 years ago

Maybe add a simple test? Sorry for the hassle

matt-gardner commented 7 years ago

The test fails on master, passes on this branch.