allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 133 forks source link

Removed scala code, moved python code to standard places #203

Closed matt-gardner closed 7 years ago

matt-gardner commented 7 years ago

This is huge. I would recommend just browsing the code corresponding to this commit, instead of looking through the "files changed".

matt-gardner commented 7 years ago

The place to browse the code is here: https://github.com/matt-gardner/deep_qa/tree/remove_scala_code. I'll worry about fixing the travis config soon.

nelson-liu commented 7 years ago

looks like you need to update pytest.ini though

matt-gardner commented 7 years ago

I don't see deep_qa/project or deep_qa/target - what do you mean?

nelson-liu commented 7 years ago

maybe its just me but when i pull down the PR locally i see those two folders --- it doesnt show up on your branch so i wouldn't worry

nelson-liu commented 7 years ago

oh duh those are gitignored files used by sbt