allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 132 forks source link

GatedAttention doesn't load correctly #218

Closed matt-gardner closed 7 years ago

matt-gardner commented 7 years ago

The GatedAttention layer doesn't implement get_config, and so the gating function doesn't get loaded correctly. You can check this in a test by specifying a non-default gating function when training the model; it will load with the wrong one.