Fix BiDAF Model Serialization

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)

Apache License 2.0

404 stars 132 forks source link

Closed nelson-liu closed 7 years ago

nelson-liu commented 7 years ago

@matt-gardner , here's the initial dump of files that we were just looking at.

matt-gardner commented 7 years ago

@nelson-liu, can you look this over? Should be good to go.

matt-gardner commented 7 years ago

Nope, some tests still failing... Let me fix this before you look at it.

matt-gardner commented 7 years ago

Ok, tests pass, it's good to look at.

matt-gardner commented 7 years ago

Ack, no, that was premature. TF passes, theano fails... Sorry for the spam.

nelson-liu commented 7 years ago

i cant approve my own PR, but this LGTM. feel free to merge if you don't have anything else to add