search

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 133 forks source link

Rename TupleMatch and make module #224

Closed BeckySharp closed 7 years ago

BeckySharp commented 7 years ago

OK -- this is just the rearranging/renaming part so I can start making a new version -- I think I need to do something diff in the custom_objects, but I don't know if I add all that it could ever be, or just add the base TupleMatch and the others fall in line... figured you'd have other changes anyway, so I can make the adjustments with the rest.

Thanks!

matt-gardner commented 7 years ago

If I've approved it with only minor changes like this, you can just merge the PR when you're satisfied. No need to have me review it again.

BeckySharp commented 7 years ago

ok :)

On Sat, Feb 25, 2017 at 10:43 AM, Matt Gardner notifications@github.com wrote:

If I've approved it with only minor changes like this, you can just merge the PR when you're satisfied. No need to have me review it again.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/allenai/deep_qa/pull/224#issuecomment-282503592, or mute the thread https://github.com/notifications/unsubscribe-auth/AFIniTGIlB_qRfS2AAy_L_Prwm7x0sPVks5rgHZTgaJpZM4ML3db .