Embedded and encoded TupleMatchers

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)

Apache License 2.0

404 stars 133 forks source link

Embedded and encoded TupleMatchers #227

Closed matt-gardner closed 7 years ago

matt-gardner commented 7 years ago

This PR allows for TupleMatchers that operate on embedded and encoded tuples, instead of just word indices. The design is slightly complicated because we need to have access to TextTrainer._embed_input and TextTrainer._get_encoder within the TupleMatcher, which requires these not actually being Layer objects. I haven't tested this yet; I'm setting this up so that Becky can implement an encoded tuple matcher, and I'm assuming there will be some tests associated with that.

BeckySharp commented 7 years ago

matt --modified the comment, want to see if it's ok?

matt-gardner commented 7 years ago

Sure, looks fine to me.