make BiDAF get_best_span support higher-order input

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)

Apache License 2.0

404 stars 133 forks source link

make BiDAF get_best_span support higher-order input #250

Closed nelson-liu closed 7 years ago

nelson-liu commented 7 years ago

Previously, this wasn't working properly since model.predict outputs a np array of shape (1,X), while I previously mistakenly assumed it was of (X,).

So i fixed it and added tests.

nelson-liu commented 7 years ago

thanks for looking at this @DeNeutoy