search

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 133 forks source link

Added CollapseToBatch and ExpandFromBatch, to handle dynamic padding #294

Closed matt-gardner closed 7 years ago

matt-gardner commented 7 years ago

I'll let the docstrings give more explanation for what's going on here.

matt-gardner commented 7 years ago

I addressed your comments @pdasigi; assuming this is good to merge. I'll merge it soon unless I hear from you.

pdasigi commented 7 years ago

LGTM, for the record.