search

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 132 forks source link

Make deep_qa pip installable #296

Closed DeNeutoy closed 7 years ago

DeNeutoy commented 7 years ago

This is ready for review - I've simplified the readme given that we now have the docs (and the wall of text of the previous one I'm not actually sure was super helpful). I've also checked that this works by installing it in a virtualenv and everything seems to work correctly. To do this, run python setup.py sdist' and pip install the resultingdeep_qa-0.1.tar.gzfile which will appear under the/dist` directory.

matt-gardner commented 7 years ago

Thanks again for getting this set up. I will look at this soon - tomorrow might be busy working on finalizing a couple of drafts to be submitted to EMNLP, but I will look at this if I get time. I still want to figure out how to get this to work with markdown instead of RST in the README; I'll look into it when I look over this PR.

matt-gardner commented 7 years ago

This looks great. I'm just going to update the README a bit myself, too, before merging this.