Moved instances into task-specific modules, implemented sorting by padding

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)

Apache License 2.0

404 stars 132 forks source link

Moved instances into task-specific modules, implemented sorting by padding #297

Closed matt-gardner closed 7 years ago

matt-gardner commented 7 years ago

This PR looks bigger than it really is. It's just moving the instances around, organizing them by task (which required changing a bunch of imports all over the code), renaming get_lengths in IndexedInstance to get_padding_lengths (which required minor fixes in a bunch of lines in the code), some documentation improvements, and adding one small method to IndexedDataset.

matt-gardner commented 7 years ago

Ok, finally got this merged with other recent PRs, and tests passing. @DeNeutoy, is this good to merge?