search

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 132 forks source link

Graph align #299

Closed BeckySharp closed 7 years ago

BeckySharp commented 7 years ago

Getting started on the graph_align model. this is the PR for the instance and associated tests.

BeckySharp commented 7 years ago

Note: I know that a TextInstance isn't really quite the right fit (you know, since it's not text-based...) but I wanted to be able to plug it in quickly to the code I already have. If you'd rather I not PR any of it, I can do that too. (or if you want it done differently) Just let me know! thanks :)

BeckySharp commented 7 years ago

another comment -- I didn't mean to push the change to tuple_inference, that was a small thing I did before I remembered that I needed to do one PR at a time. The first push, I didn't screw up, when I added the docs stuff I screwed up and did -am on my commit... :( so...... is it ok? that PR is in the works anyway............... sorry.

BeckySharp commented 7 years ago

merging per approval