search

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 132 forks source link

add parameter logging #301

Closed DeNeutoy closed 7 years ago

DeNeutoy commented 7 years ago

fixes #300

DeNeutoy commented 7 years ago

@matt-gardner This now works except I am having some issues with model serialisation - I think you might know more about that than me. Basically, Keras can't serialise the Param objects which are arguments to layers....

DeNeutoy commented 7 years ago

@matt-gardner this now has all tests passing - can you just check you are happy with what I have done for the recurrence classes - in order to not use dicts and pop off arguments but retain the same interface, I've had to allow passing arguments which aren't used. Don't know what you think about that, but I think changing it will be ugly because we'd then have to have conditions in the _get_recurrence_mode() method of the MemoryNetwork.

DeNeutoy commented 7 years ago

Bah, I rebased instead of merging. @matt-gardner is this ok, given that the commits will be squashed anyway?