search

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 133 forks source link

Upgrade to python 3.6 #310

Open matt-gardner opened 7 years ago

matt-gardner commented 7 years ago

I think the main benefit to this is the ability to give type annotations on variables, instead of just methods and method arguments. What needs to be done is just updating all of the continuous integration services / build tools to use the new python version, and make sure everything still works.

matt-gardner commented 7 years ago

I saw a stack trace that made me think this might not be so easy. Some of the libraries we depend on might not be compatible with python 3.6. In particular, I'm guessing that overrides isn't. We'd probably need to patch it and submit a PR here before we can actually migrate ourselves.

nelson-liu commented 7 years ago

Importantly, tensorflow isn't either.

nelson-liu commented 7 years ago

Whoops, never mind looks like you can still install it, but you have to provide a link to a wheel instead of just pip install tensorflow