allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 133 forks source link

Cleaning up the parameter API a bit #318

Closed matt-gardner closed 7 years ago

matt-gardner commented 7 years ago

@DeNeutoy, I had an idea that I think you'll be happy with. I realized that we never used the default argument to pop_choice_with_default, so we didn't need it. That made it so there's only one default option to pop_choice, and the API is now simpler and cleaner.

While I was at it, I improved the documentation a bit, and cleaned up a few other methods dealing with parameters.