allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 133 forks source link

See if masking makes a difference with a CNN encoder #323

Open matt-gardner opened 7 years ago

matt-gardner commented 7 years ago

It's standard to just ignore masking when using a CNN on word / character sequences, because the max pooling can effectively ignore the padding tokens, anyway. It'd be interesting to actually verify that this is true, by implementing masking for our CNN and seeing what difference it makes, if any.

Pretty low priority, though. Just getting a thought out of my head and into an issue tracker.