search

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 133 forks source link

Peek across #327

Closed BeckySharp closed 7 years ago

BeckySharp commented 7 years ago

Peek-across model. I'll say that line 38 of subtract_minimum particularly bothers me (the arbitrary high number...) and I think there is likely a much more elegant way to accomplish the whole process...

matt-gardner commented 7 years ago

Pretty surprised that the layer test passed, but it's not working when I put it in an actual model. I'll look into what's going on with this.