Fix paths in the code to be OS independent

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)

Apache License 2.0

404 stars 133 forks source link

Fix paths in the code to be OS independent #335

Open matt-gardner opened 7 years ago

matt-gardner commented 7 years ago

I'm pretty sure this won't work on Windows at the moment, because we have plenty of places where / is hard-coded, instead of using os.path.join. This should be fixed.

It's also super low priority for us, and really hard to know if we've found everything, because we just use linux and macOS. Contributions welcome here.

morrme commented 7 years ago

I use windows. How can I help?

matt-gardner commented 7 years ago

Try running things, see what breaks, and submit PRs to fix it. If it just works already, then great, we can close this issue.

nelson-liu commented 7 years ago

to be specific, it'd be great to verify that unit tests at least work on windows.