search

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 133 forks source link

Move to ECR for docker images #337

Closed DeNeutoy closed 7 years ago

matt-gardner commented 7 years ago

Fixes #303.

DeNeutoy commented 7 years ago

I'm getting an error when running the actual script which isn't due to this change - I think it was to do with removing the paths when I moved run_model into deep_qa:

Traceback (most recent call last):
  File "scripts/run_model.py", line 4, in <module>
    from deep_qa import run_model
ImportError: No module named 'deep_qa'

But this doesn't happen when I run it locally. This is some python path thing but I'm not sure what - I am running it from the root of deep_qa, so it should already be set, right?

matt-gardner commented 7 years ago

Yeah, I'm about to fix that in another PR, that also adds a bit of functionality. I'll submit it now.