search

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 133 forks source link

Pinned pandas version #345

Closed matt-gardner closed 7 years ago

matt-gardner commented 7 years ago

Newer version makes our build fail.

In general, I think I prefer pinning versions wherever possible, so that someone else upgrading their software doesn't break our code. We can upgrade to a new pinned version when there's a compelling reason to do so.

matt-gardner commented 7 years ago

Well, the issue with pinning versions is conflicting versions in transitive dependencies... I guess the policy should be, if there's a version upgrade that breaks our build, we pin the version, then open an issue to remove the pin at some point?