Simplify installation instructions

allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)

Apache License 2.0

404 stars 133 forks source link

Simplify installation instructions #388

Closed schmmd closed 7 years ago

schmmd commented 7 years ago

Move Python environment initialization scripts to a script (scripts/install_requirements.sh).
Add an argument to the Dockerfile which controls whether a CPU or a GPU environment is created.

schmmd commented 7 years ago

Unfortunately the Dockerfile doesn't create a great environment, since it doesn't contain all the files in the CWD (although we could change that). Also, the ENTRYPOINT is a bit annoying and needs to be overridden on the CLI (docker run -it deep_qa_cpu --entrypoint=/bin/bash).

matt-gardner commented 7 years ago

I don't understand the issue about overriding the entry point - what's going on there?

schmmd commented 7 years ago

@matt-gardner there's no issue overriding the entrypoint--it works fine--you just need to know to do it otherwise it will try and execute the job that's specified.