allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 132 forks source link

Multi gpu generator compatibility #391

Closed DeNeutoy closed 7 years ago

DeNeutoy commented 7 years ago

Threading the batch size through Trainer and TextTrainer might not be the best way to do this, because it is probably a bit confusing as to why we aren't using the self.batch_size attribute. Aside from that, this appears to work smoothly.