allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 132 forks source link

Make VectorMatrixMerge handle more general cases #392

Closed matt-gardner closed 7 years ago

matt-gardner commented 7 years ago

This is for @bhavanadalvi - this PR makes it possible to use VectorMatrixMerge to concatenate hand-computed features onto word embeddings, basically doing the expand and the concatenate in a single layer.

matt-gardner commented 7 years ago

Something got messed up in github's connection to travis, I think because I merged master immediately after pushing the commit. Travis is actually passing. I'm going to merge this now.