allenai / deep_qa

A deep NLP library, based on Keras / tf, focused on question answering (but useful for other NLP too)
Apache License 2.0
404 stars 132 forks source link

Refactoring the instance objects some #75

Closed matt-gardner closed 8 years ago

matt-gardner commented 8 years ago

The point of this refactoring is to make it easier to add a new type. I want to add an Instance type that has a question and associated answer options. To do this, and still allow background data to be associated with the instance, I made the BackgroundInstance use composition instead of inheritance, and I made the code that reads data take an instance type.

This one depends on the previous two.