search

allenai / ike

Build tables of information by extracting facts from indexed text corpora via a simple and effective query language.
http://allenai.org/software/interactive-knowledge-extraction/
Apache License 2.0
56 stars 20 forks source link

[CLOSED] Wipes results when the target changes #169

Closed sbhaktha closed 8 years ago

sbhaktha commented 8 years ago

Issue by dirkgr Thu Jul 23 00:39:13 2015 Originally opened as https://github.com/allenai/okcorpus/pull/167

Fixes #112.

Sorry for another code review so quickly. The rotation of people for this stuff is rather small. Fortunately, so is this pull request.

This makes OKC wipe the results when the number of columns in the target table changes. We want to do this because the search results don't make sense for a different number of columns, and actually let you put garbage into the tables without this change.

dirkgr included the following code: https://github.com/allenai/okcorpus/pull/167/commits

sbhaktha commented 8 years ago

Comment by jkinkead Thu Jul 23 17:31:33 2015

A few requests, especially about uncommented, single-character variables.

sbhaktha commented 8 years ago

Comment by jkinkead Thu Jul 23 20:40:30 2015

Awesome! LGTM - merging. :)