allenai / ike

Build tables of information by extracting facts from indexed text corpora via a simple and effective query language.
http://allenai.org/software/interactive-knowledge-extraction/
Apache License 2.0
56 stars 20 forks source link

[CLOSED] Add tooltip for +/- buttons #191

Closed sbhaktha closed 8 years ago

sbhaktha commented 8 years ago

Issue by sbhaktha Thu Apr 21 22:28:27 2016 Originally opened as https://github.com/allenai/okcorpus/pull/189


@dirkgr : quite minor. addresses https://trello.com/c/1bumXGvL/8-user-request-minor-add-tooltip-to-buttons-on-search-results-pages


sbhaktha included the following code: https://github.com/allenai/okcorpus/pull/189/commits

sbhaktha commented 8 years ago

Comment by dirkgr Fri Apr 22 17:55:53 2016


LGTM. I'd highlight "positive example" and "negative example" in the tooltips, because otherwise they look very similar to each other, but either way is fine.

sbhaktha commented 8 years ago

Comment by sbhaktha Fri Apr 22 21:15:00 2016


good point. done!

sbhaktha commented 8 years ago

Comment by sbhaktha Fri Apr 22 21:15:08 2016


Will merge on green.