search

allenai / ike

Build tables of information by extracting facts from indexed text corpora via a simple and effective query language.
http://allenai.org/software/interactive-knowledge-extraction/
Apache License 2.0
56 stars 20 forks source link

[CLOSED] Show message on browsers we do not currently support #208

Closed sbhaktha closed 8 years ago

sbhaktha commented 8 years ago

Issue by sbhaktha Wed May 25 20:56:24 2016 Originally opened as https://github.com/allenai/okcorpus/pull/206

@dirkgr : This checks the browser the user is currently on and shows a message if it's any browser other than Chrome, Safari and Opera-- the ones we've used internally so far on which IKE works fine. OAuth doesn't seem to work on Firefox/IE + the demo looks terrible. Mobile site is also ugly and I don't think anyone would want to build tables on their phone.

@codeviking : here is the code.

sbhaktha included the following code: https://github.com/allenai/okcorpus/pull/206/commits

sbhaktha commented 8 years ago

Comment by dirkgr Wed May 25 21:20:08 2016

What about tablets?

sbhaktha commented 8 years ago

Comment by codeviking Wed May 25 21:23:37 2016

Tablets will be caught by the Mobi regular expression, so they'll fall into that bucket.

sbhaktha commented 8 years ago

Comment by codeviking Wed May 25 21:24:54 2016

LGTM! Nice work. Writing good ole' native JS is painful, isn't it!? :)

sbhaktha commented 8 years ago

Comment by sbhaktha Wed May 25 22:07:36 2016

thnx guys, so I'll merge, dirk, unless you have something else in the next 10 mins. :)

sbhaktha commented 8 years ago

Comment by dirkgr Wed May 25 22:12:05 2016

I thought it would be quite reasonable to use it on tablets. But let's not overcomplicate things. If you're happy to not support tablets, LGTM.

sbhaktha commented 8 years ago

Comment by sbhaktha Wed May 25 22:14:05 2016

Yeah I agree it would be good to add that support but right now it would take more testing and potentially CSS fixups, so I am ok addressing those later.