search

allenai / ike

Build tables of information by extracting facts from indexed text corpora via a simple and effective query language.
http://allenai.org/software/interactive-knowledge-extraction/
Apache License 2.0
56 stars 20 forks source link

Make ACL Docs Index available on public demo #231

Closed sbhaktha closed 7 years ago

sbhaktha commented 7 years ago

@dirkgr : Change per Oren. He wants us to show the ACL papers index in the public demo, and have only that be selected by default. The prod deploy configuration is changing appropriately in a separate PR in the deploy repo -- coming up.

sbhaktha commented 7 years ago

actually we keep the SearchApps wrapped in a Future, so we would have to map it every time to get the default setting. I think this is better.

dirkgr commented 7 years ago

No, it's not better. Look at how much code you added to support that one level of indirection. And you only need that setting in two places! In one of them, it's already taken care of because it filters by the search apps that are ready. In the second place, you can just do the same thing we're doing in the first place.

sbhaktha commented 7 years ago

I see what you're saying. Done! I'll merge unless you have something else.