Closed sbhaktha closed 8 years ago
Comment by codeviking Fri Apr 3 19:32:34 2015
Oh, also I failed to note that I switched the build from reactify to babel. Babel enables ES6 syntax if you guys choose to use it. Things like Map, Set, etc...
Comment by dirkgr Fri Apr 3 20:17:43 2015
Won’t this make things less debuggable, since we’re debugging the compiled code as it is?
On April 3, 2015 at 12:32:36, Sam Skjonsberg (notifications@github.com) wrote:
Oh, also I failed to note that I switched the build from reactify to babel. Babel enables ES6 syntax if you guys choose to use it. Things like Map, Set, etc...
— Reply to this email directly or view it on GitHub.
Comment by codeviking Fri Apr 3 20:18:08 2015
@dirkgr Nope! Source maps ftw!
(This syrup release provides source map support and support for the debugger
keyword).
Also, if you guys feel like the build is slow you can toggle compressJs: false
in the gulpfile to speed tings up. The slowest part of the build currently is the compression step.
Issue by codeviking Fri Apr 3 19:29:25 2015 Originally opened as https://github.com/allenai/okcorpus/pull/75
@afader @chrisc36 @dirkgr
This applies the latest syrup version, which has some logging and speed improvements.
A few notes:
.jshintrc
file such that jshint "plays" well with jsx -- but I kept the javascript linter disabled. If you want to enable it simply edit the gulpfile and removedisableJsHint: true
. I tried doing this but there's a lot of lint errors right now -- at one point in the near term we should resolve these and renable the linter (as it helps catch errors prior to even running the code in the browser).npm run build
andnpm run watch
. These are equivalent togulp build
andgulp watch
, respectively.npm install
inwebapp
. Things won't work if you don't (as this syrup version is incompatible with 0.0.*).codeviking included the following code: https://github.com/allenai/okcorpus/pull/75/commits