allenai / ike

Build tables of information by extracting facts from indexed text corpora via a simple and effective query language.
http://allenai.org/software/interactive-knowledge-extraction/
Apache License 2.0
56 stars 20 forks source link

[CLOSED] Update to syrup 0.1.3 #77

Closed sbhaktha closed 8 years ago

sbhaktha commented 8 years ago

Issue by codeviking Fri Apr 3 19:29:25 2015 Originally opened as https://github.com/allenai/okcorpus/pull/75


@afader @chrisc36 @dirkgr

This applies the latest syrup version, which has some logging and speed improvements.

A few notes:


codeviking included the following code: https://github.com/allenai/okcorpus/pull/75/commits

sbhaktha commented 8 years ago

Comment by codeviking Fri Apr 3 19:29:41 2015


@afader I'm assigning this to you for a quick review.

sbhaktha commented 8 years ago

Comment by codeviking Fri Apr 3 19:32:34 2015


Oh, also I failed to note that I switched the build from reactify to babel. Babel enables ES6 syntax if you guys choose to use it. Things like Map, Set, etc...

https://babeljs.io/

sbhaktha commented 8 years ago

Comment by dirkgr Fri Apr 3 20:17:43 2015


Won’t this make things less debuggable, since we’re debugging the compiled code as it is?

On April 3, 2015 at 12:32:36, Sam Skjonsberg (notifications@github.com) wrote:

Oh, also I failed to note that I switched the build from reactify to babel. Babel enables ES6 syntax if you guys choose to use it. Things like Map, Set, etc...

https://babeljs.io/

— Reply to this email directly or view it on GitHub.

sbhaktha commented 8 years ago

Comment by codeviking Fri Apr 3 20:18:08 2015


@dirkgr Nope! Source maps ftw!

(This syrup release provides source map support and support for the debugger keyword).

Also, if you guys feel like the build is slow you can toggle compressJs: false in the gulpfile to speed tings up. The slowest part of the build currently is the compression step.

sbhaktha commented 8 years ago

Comment by codeviking Tue Apr 7 14:40:17 2015


Ping! Do we want this merged in?

sbhaktha commented 8 years ago

Comment by dirkgr Tue Apr 7 16:44:57 2015


:+1:

sbhaktha commented 8 years ago

Comment by afader Tue Apr 7 19:06:32 2015


Looks good, thanks for the help, @codeviking.