search

allenai / mmda

multimodal document analysis
Apache License 2.0
159 stars 18 forks source link

Bugfix/egork/all row ids out of range #192

Closed egork520 closed 1 year ago

egork520 commented 1 year ago

Fixing issue https://github.com/allenai/mmda/issues/191

kyleclo commented 1 year ago

can you add a test case that captures what this PR is supposed to fix?

egork520 commented 1 year ago

can you add a test case that captures what this PR is supposed to fix?

Hello @kyleclo I think it is ready now

egork520 commented 1 year ago

@kyleclo I've added 2 more test cases with empty-non-empy and non-empty-empty pages, please take a look.