search

allenai / mmda

multimodal document analysis
Apache License 2.0
158 stars 18 forks source link

update archive path for new bib detector #225

Closed dmh43 closed 1 year ago

geli-gel commented 1 year ago

I think it makes more sense to include this change as part of a larger pr that updates the bib detector model to no longer use the vila stuffs

dmh43 commented 1 year ago

@geli-gel I can't find that code in this codebase. I searched for HVILAPredictor but only found some examples, not the actual code used.

dmh43 commented 1 year ago

I just changed the default required number of vila references to 0. I couldnt find where the actual config is located (maybe that's in another repo?)

geli-gel commented 1 year ago

The interface code under the Predictor part shows where the predictor code comes from: https://github.com/allenai/mmda/blob/271334c08bfea6a06b0a8f3c26b853a25627e9ec/src/ai2_internal/bibentry_detection_predictor/interface.py#L86 (which is this, place where min_vila_bib_rows is used is highlighted: https://github.com/allenai/mmda/blob/main/src/mmda/predictors/d2_predictors/bibentry_detection_predictor.py#L157)

dmh43 commented 1 year ago

@geli-gel like that?

geli-gel commented 1 year ago

Oh - you'll have to bump the mmda version though

dmh43 commented 1 year ago

@geli-gel like that?

cmwilhelm commented 1 year ago

Does tt verify pass?

[edit] Link to docs: https://github.com/allenai/timo/blob/main/docs/timo-tools/userguide.md#step-5-make-sure-it-all-works-end-to-end

dmh43 commented 1 year ago

i believe this should be good to go now @geli-gel @cmwilhelm