bugfix for box_groups_to_span_groups when center=True

allenai / mmda

multimodal document analysis

Apache License 2.0

158 stars 18 forks source link

bugfix for box_groups_to_span_groups when center=True #278

Closed geli-gel closed 1 year ago

geli-gel commented 1 year ago

this is a bug fix for an error made in https://github.com/allenai/mmda/pull/276 It's possible to find tokens from the original Document overlapping with the MergedSpan SpanGroup that are already allocated to a different SpanGroup, so we need to check first if it's in the list of available tokens before attempting to remove it.

todo:

[x] publish new version

geli-gel commented 1 year ago

@regan-huff could you try merging this for me? for some reason the button isn't working for me, appears to be and then goes back to "Confirm squash and merge" after a little while

regan-huff commented 1 year ago

@geli-gel failed for me too, will try again in a bit