Add default seed (to match jax code)

allenai / open-instruct

Apache License 2.0

1.22k stars 166 forks source link

Add default seed (to match jax code) #127

Closed jacob-morrison closed 7 months ago

hamishivi commented 7 months ago

@jacob-morrison Next time you submit a PR could you let Yizhong or I know before merging? For this, it's small and fine but just in case we are doing a code freeze or similar.

jacob-morrison commented 7 months ago

Oh yeah definitely, sorry about that! I think I just saw it was merge-able sometime after I had sent it out and didn't look closely to see if it had actually been reviewed, won't do that again.

hamishivi commented 7 months ago

nw, I added a setting to require a review so at least someone has to approve a merge :)